signapi: Change API to also return a success message
authorColin Walters <walters@verbum.org>
Wed, 17 Jun 2020 00:22:49 +0000 (00:22 +0000)
committerColin Walters <walters@verbum.org>
Wed, 17 Jun 2020 00:33:47 +0000 (00:33 +0000)
commit36258036ae1388c728eec0237b283e225f64a7b1
tree1616ed7bc9d2e7ae0b946c01e894c0b5e39e65c2
parentb2dde24f00699822c27b4ab453a4340ddc3c2245
signapi: Change API to also return a success message

This is the dual of https://github.com/ostreedev/ostree/pull/2129/commits/1f3c8c5b3de978f6e069c24938967f823cce7ee8
where we output more detail when signapi fails to validate.

Extend the API to return a string for success, which we output
to stdout.

This will help the test suite *and* end users validate that the expected
thing is happening.

In order to make this cleaner, split the "verified commit" set
in the pull code into GPG and signapi verified sets, and have
the signapi verified set contain the verification string.

We're not doing anything with the verification string in the
pull code *yet* but I plan to add something like
`ostree pull --verbose` which would finally print this.
src/libostree/ostree-repo-pull-private.h
src/libostree/ostree-repo-pull-verify.c
src/libostree/ostree-repo-pull.c
src/libostree/ostree-sign-dummy.c
src/libostree/ostree-sign-dummy.h
src/libostree/ostree-sign-ed25519.c
src/libostree/ostree-sign-ed25519.h
src/libostree/ostree-sign.c
src/libostree/ostree-sign.h
src/ostree/ot-builtin-sign.c
tests/test-signed-commit.sh